CMake: Adjust the download directory and name of external dependencies #4511
Conversation
uklotzde
changed the title
|
@Holzhaus I have no idea what's wrong with the changelog. Ideally, the |
|
|
|
It's failing because the metainfo.xml changes are missing. |
The file name in the URL doesn't match the actual file name that is downloaded from GitHub.
Thanks. Forgot to re-enable my pre-commit hooks. |
|
I remember that pre-commit failed with strange error messages after upgrading from Fedora 34 to 35. Happened for this and other projects. Had to re-install it which removed the hooks. |
|
Same for me. The hooks hardcoded python3.9 for some reason and fedora 35 ships python3.10. I also fixed it by reinstalling the pre-commit hooks. |
CMakeLists.txt
Outdated
| @@ -1808,7 +1808,8 @@ target_include_directories(mixxx-lib SYSTEM PUBLIC lib/fidlib) | |||
| target_link_libraries(mixxx-lib PRIVATE fidlib) | |||
|
|
|||
| # KeyFinder | |||
| find_package(KeyFinder) | |||
| set(LIBKEYFINDER_VERSION 2.2.4) | |||
There was a problem hiding this comment.
| set(LIBKEYFINDER_VERSION 2.2.4) | |
| set(LIBKEYFINDER_VERSION 2.2.5) |
CHANGELOG.md
Outdated
| ### Packaging | ||
|
|
||
| * Downloads of external dependencies are placed in build/downloads | ||
| * The sources for libkeyfinder are now expected in build/downloads/libkeyfinder-2.2.4.zip instead of build/download/libkeyfinder/v2.2.4.zip |
There was a problem hiding this comment.
| * The sources for libkeyfinder are now expected in build/downloads/libkeyfinder-2.2.4.zip instead of build/download/libkeyfinder/v2.2.4.zip | |
| * The sources for libkeyfinder are now expected in build/downloads/libkeyfinder-2.2.5.zip instead of build/download/libkeyfinder/v2.2.5.zip |
|
The hash of the download needs to be updated too. |
The file name in the URL doesn't match the actual file name that is downloaded from GitHub.
Reduces the friction for external downloads and allows to simplify the packaging.